Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary model package import to avoid ambiguous class references #20124

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

beikov
Copy link
Contributor

@beikov beikov commented Nov 17, 2024

Fixes #20125

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@beikov beikov changed the title Remove unnecessary model package import to avoid ambiguous class references [#20125] Remove unnecessary model package import to avoid ambiguous class references Nov 17, 2024
@wing328
Copy link
Member

wing328 commented Nov 18, 2024

@beikov thanks for the PR

let's give it a try

@wing328 wing328 added Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Nov 18, 2024
@wing328 wing328 added this to the 7.10.0 milestone Nov 18, 2024
@wing328 wing328 merged commit 4185782 into OpenAPITools:master Nov 18, 2024
72 checks passed
@wing328 wing328 changed the title [#20125] Remove unnecessary model package import to avoid ambiguous class references Remove unnecessary model package import to avoid ambiguous class references Nov 18, 2024
@beikov beikov deleted the json-node-fix branch November 18, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unnecessary model package import in JSON causes ambiguous class reference
3 participants