Build script work #835
Merged
Build script work #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awhile back, I had added code to the build script to avoid publishing multiple times for the same RID. However, that failed to take into account the "default" RID, which is intended to represent the current machine. When we encounter "default", we substitute the RID for the current machine, which means that we'd never actually publish that same RID. This resulted in builds being missing if the RID matched the current machines. In particular, this resulted in ubuntu 14 builds being missing from Travis because that's the "default".
This was referenced Apr 27, 2017
david-driscoll
approved these changes
Apr 27, 2017
This was referenced May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658
Fixes #639
The additionally Linux distros is really a temporary measure since we'll be moving to an embedded Mono as part of #666. However, this will at least allow folks to build on those machines.