allow loglevel to be passed in as an argument #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
changed the title
willl
changed the title
willl
changed the title
willl
reviewed
Dec 22, 2016
| @@ -48,6 +48,15 @@ public static void Main(string[] args) | |||
| enumerator.MoveNext(); | |||
| serverPort = int.Parse((string)enumerator.Current); | |||
| } | |||
| else if (arg.ToLowerInvariant() == "-loglevel") | |||
There was a problem hiding this comment.
Would it be better to use string.Equals(arg, "-loglevel", StringComparison.OrdinalIgnoreCase) rather than ToLowerInvariant() here?
willl
approved these changes
Dec 23, 2016
david-driscoll
approved these changes
Jan 6, 2017
There was a problem hiding this comment.
LGTM
Added @DustinCampbell in case he had any arguments, but it looks fine to me. -v will always override -loglevel which makes sense.
|
Nope. No complaints. Although, we should consolidate these arguments at some point. |
DustinCampbell
approved these changes
Jan 6, 2017
|
great. let's punch this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new startup argument
-loglevel {value}, which allows OmniSharp logging level to be configured from outside.At the moment there is only a
-vswitch which toggles betweeninformationanddebuglevels, but there is no way to set up more granular logging levels. For now I have not removed the-vswitch yet, so as to not break any existing use case.The PR will allow adding this feature dotnet/vscode-csharp#993 to the editors.