Add uptime check #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MebinAbraham
reviewed
Nov 5, 2019
| @@ -35,3 +35,7 @@ variable "project_team" { | |||
| description = "The team this project belongs to, for billing and reporting purposes, etc" | |||
| default = "eq" | |||
| } | |||
|
|
|||
| variable "uptime_check_host" { | |||
There was a problem hiding this comment.
Should add this to terraform.tfvars.example since it is mandatory.
MebinAbraham
reviewed
Nov 5, 2019
| display_name = "${var.uptime_check_host}" | ||
| timeout = "5s" | ||
| period = "60s" | ||
|
|
There was a problem hiding this comment.
I had to add project = "${var.stackdriver_workspace}" for this to work.
There was a problem hiding this comment.
Fixed. Mine worked as my project id is the same as my stackdriver workspace.
MebinAbraham
reviewed
Nov 5, 2019
monitoring_alerts.tf
Outdated
| type = "uptime_url" | ||
|
|
||
| labels = { | ||
| project_id = "${var.stackdriver_workspace}" |
There was a problem hiding this comment.
This isn't needed and I think we should remove it.
There was a problem hiding this comment.
Ok, the Terraform doc isn't clear and it's in their example. Removed.
MebinAbraham
previously approved these changes
Nov 5, 2019
JamesGardiner
suggested changes
Nov 5, 2019
MebinAbraham
reviewed
Nov 5, 2019
MebinAbraham
approved these changes
Nov 5, 2019
JamesGardiner
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the uptime check that is currently manually created in production.
Configuring SSL certificate validation is not currently possible in Terraform - hashicorp/terraform-provider-google-beta#1243.
The conditions config is derived from https://cloud.google.com/monitoring/alerts/policies-in-json.