Skip to content

[12.0][MIG] web_sheet_full_width #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 9, 2021

Conversation

vvrossem
Copy link

@vvrossem vvrossem commented Dec 3, 2020

As I've read in #1048, this module is now integrated in web_responsive.
However, a client used web_sheet_full_width in 9.0. In 12.0, he doesn't wish all the features that are included in web_responsive, hence the migration.

@vvrossem vvrossem force-pushed the 12.0-mig-web_sheet_full_width branch from f7fb4eb to 7a95f7b Compare December 4, 2020 09:10
Copy link

@lfreeke lfreeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go

@dreispt
Copy link
Member

dreispt commented Mar 9, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1754-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7a8c852 into OCA:12.0 Mar 9, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dac2669. Thanks a lot for contributing to OCA. ❤️

@vvrossem
Copy link
Author

Thank you @dreispt for having merged this PR :)

@robinkeunen robinkeunen deleted the 12.0-mig-web_sheet_full_width branch August 2, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.