Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.green: remove failing test #335757

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

gador
Copy link
Member

@gador gador commented Aug 19, 2024

Description of changes

test_command fails with:
AttributeError: 'Distribution' object has no attribute 'tests_require'. Did you mean: 'extras_require'?

Upstream issue has been reported to:
CleanCut/green#299

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

test_command fails with:
`AttributeError: 'Distribution' object has no attribute 'tests_require'. Did you mean: 'extras_require'?`

Upstream issue has been reported to:
CleanCut/green#299

Signed-off-by: Florian Brandes <[email protected]>
@gador
Copy link
Member Author

gador commented Aug 21, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 335757 run on x86_64-linux 1

7 packages built:
  • passExtensions.pass-audit
  • passExtensions.pass-audit.dist
  • passExtensions.pass-audit.man
  • python311Packages.green
  • python311Packages.green.dist
  • python312Packages.green
  • python312Packages.green.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python311Packages.green.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/x0dhrgfmj95p8ag4ajyn2n45vlliq2m9-python3.11-green-4.0.2-dist' from 'daemon'
When evaluating attribute ‘python311Packages.green.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/green/default.nix:51:5:

   |
51 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.green:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/5mdy4y5lhnzrnrfh3bacs0zagb1pja03-python3.11-green-4.0.2' from 'daemon'
When evaluating attribute ‘python311Packages.green’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/green/default.nix:51:5:

   |
51 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.green.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

error: build log of '/nix/store/5mhi4gld50d90kwygmxzz9sa8c1bd0h0-python3.12-green-4.0.2-dist' is not available
When evaluating attribute ‘python312Packages.green.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/green/default.nix:51:5:

   |
51 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.green:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

error: build log of '/nix/store/pjq04lag039pswm875hh3bqh69vjf9xp-python3.12-green-4.0.2' is not available
When evaluating attribute ‘python312Packages.green’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/green/default.nix:51:5:

   |
51 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

@gador
Copy link
Member Author

gador commented Aug 21, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 335757 run on aarch64-darwin 1

4 packages built:
  • python311Packages.green
  • python311Packages.green.dist
  • python312Packages.green
  • python312Packages.green.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python311Packages.green.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/iy850lq6kzrz98qxki5lf1hblfmg5wz0-python3.11-green-4.0.2-dist' from 'daemon'
When evaluating attribute ‘python311Packages.green.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/green/default.nix:51:5:

   |
51 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.green:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/876cs87n2v0mjhl3xc1ak6gxvlvi34ka-python3.11-green-4.0.2' from 'daemon'
When evaluating attribute ‘python311Packages.green’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/green/default.nix:51:5:

   |
51 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.green.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/ldyn50jvn7wr4f1rfr25ma5xgw9f8www-python3.12-green-4.0.2-dist' from 'daemon'
When evaluating attribute ‘python312Packages.green.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/green/default.nix:51:5:

   |
51 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.green:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/gj1ki4lykgp0pgbwlp5n1y8j09vc3rs8-python3.12-green-4.0.2' from 'daemon'
When evaluating attribute ‘python312Packages.green’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/green/default.nix:51:5:

   |
51 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

@gador gador merged commit 9518f84 into NixOS:master Aug 21, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant