fix: pushRemote.branch string extraction #1659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully the linter is happy now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current use of
unpackandvim.splitto extract the branch name of an upstream ref fails to properly handle branch names containing forward slash (/) symbols. In particular, it discards the branch name's portion including and following the first occurrence of a/symbol.For example:
pushRemote.ref == "origin/branch/name"pushRemote.branch (expected) == "branch/name"pushRemote.branch (actual) == "branch"UI example:
This PR replaces this usage of
unpackandvim.splitwith a regex match that properly handles branch names containing/symbols.