-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up GFS post-processing workflow scripts and add back ICEG, ICETMP #1146
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
these capabilities have been implemented in the global-workflow, and have been tested by the UPP team.
@aerorahul That's right. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @WenMeng-NOAA !
@gspetro-NOAA This PR is not ready for conducting the UPP RTs yet. Could you confirm the script 'run_upp' under scripts/ can be removed? |
Solved conflicts.
@WenMeng-NOAA According to the release/gfs_v16 branch, the variable ICEG is not featured within files |
@ChristopherHill-NOAA Good catching. I will revert these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked good. Thank you.
@gspetro-NOAA You may start the UPP RTs on R&D machines. For your reference, my RTs on Hera are at /home/Wen.Meng/stmp2/UPP-RTs:
|
The UPP RTs have been completed on WCOSS2. The gfs baseline needs an update since two new variables are added in the master file.
|
@BenjaminBlake-NOAA Please review the ifi job script updates. |
@WenMeng-NOAA The IFI script changes look good to me - thanks |
This PR addresses the following issues: