Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GFS post-processing workflow scripts and add back ICEG, ICETMP #1146

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA WenMeng-NOAA commented Feb 21, 2025

This PR addresses the following issues:

  1. Clean up GFS post workflow scripts #1097 to clean up the legacy GFS post-processing workflow scripts in UPP repository.
  2. Add ICEG Back as the GFS ATOMS Product #1149 to add ICEG back in GFS control files
  3. Remove legacy gfs control files
  4. Update permissions of IFI scripts in ci/jobs-dev directory #1151 to update permissions of IFI scripts in ci/jobs-dev directory

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
these capabilities have been implemented in the global-workflow, and have been tested by the UPP team.

@WenMeng-NOAA
Copy link
Collaborator Author

looks good to me. these capabilities have been implemented in the global-workflow, and have been tested by the UPP team.

@aerorahul That's right. Thanks!

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @WenMeng-NOAA !

@WenMeng-NOAA
Copy link
Collaborator Author

@gspetro-NOAA This PR is not ready for conducting the UPP RTs yet. Could you confirm the script 'run_upp' under scripts/ can be removed?

@WenMeng-NOAA WenMeng-NOAA linked an issue Feb 24, 2025 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA changed the title Clean up GFS post-processing workflow scripts Clean up GFS post-processing workflow scripts and add back ICEG Feb 24, 2025
@ChristopherHill-NOAA
Copy link
Contributor

ChristopherHill-NOAA commented Feb 24, 2025

@WenMeng-NOAA According to the release/gfs_v16 branch, the variable ICEG is not featured within files postcntrl_gfs_anl.xml or postxconfig-NT-GFS-ANL.txt. Should we proceed to add ICEG to postcntrl_gfs_anl.xml and postxconfig-NT-gfs-anl.txt within this PR?

@WenMeng-NOAA
Copy link
Collaborator Author

@WenMeng-NOAA According to the release/gfs_v16 branch, the variable ICEG is not featured within files postcntrl_gfs_anl.xml or postxconfig-NT-GFS-ANL.txt. Should we proceed to add ICEG to postcntrl_gfs_anl.xml and postxconfig-NT-gfs-anl.txt within this PR?

@ChristopherHill-NOAA Good catching. I will revert these changes.

@WenMeng-NOAA WenMeng-NOAA changed the title Clean up GFS post-processing workflow scripts and add back ICEG Clean up GFS post-processing workflow scripts and add back ICEG, ICETMP Feb 24, 2025
Copy link
Contributor

@HuiyaChuang-NOAA HuiyaChuang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good. Thank you.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Feb 26, 2025
@WenMeng-NOAA
Copy link
Collaborator Author

@gspetro-NOAA You may start the UPP RTs on R&D machines. For your reference, my RTs on Hera are at /home/Wen.Meng/stmp2/UPP-RTs:
Wen.Meng@hfe08 UPP-RTs$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp 75 Feb 26 17:19 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp 21229 Feb 26 17:27 fv3gfs_2019083000/gfs.t00z.master.grb2f006.diff
-rw-r--r-- 1 Wen.Meng stmp 21229 Feb 26 17:27 fv3gfs_2019083000_pe_test/gfs.t00z.master.grb2f006.diff```

There will be a baseline update for gfs since two variables are added in the gfs master file in this PR.

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs have been completed on WCOSS2. The gfs baseline needs an update since two new variables are added in the master file.

854:2274757959:d=2019083000:ICEG:10 m above mean sea level:6 hour fcst:
1052:2891375279:d=2019083000:ICETMP:surface:6 hour fcst:

@WenMeng-NOAA
Copy link
Collaborator Author

@BenjaminBlake-NOAA Please review the ifi job script updates.

@BenjaminBlake-NOAA
Copy link
Collaborator

@WenMeng-NOAA The IFI script changes look good to me - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. GFSV17 Ready for Review This PR is ready for code review.
Projects
None yet
8 participants