Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabbar): typescript error #753

Merged
merged 1 commit into from
Oct 21, 2020
Merged

fix(module: tabbar): typescript error #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions components/tab-bar/tab-bar-item.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ export class TabBarItemComponent extends TabPaneComponent {
@Input()
key: string = '';
@Input()
title: string = '';
@Input()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TabBarItemComponent 继承自 TabPaneComponent
在 TabPaneComponent 中已经有了title的input与get set.
那么 TabBarItemComponent 本身也就有了, 没必要重新声明一次.
本地跑过单测了, 全部成功, 项目也run了, title没出现异常.

dot: boolean = false;
@Input()
badge: number | string = null;
Expand Down