Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature(clipboard): remove PICGO_ENV and script files #754

Closed
wants to merge 4 commits into from

Conversation

upupming
Copy link
Contributor

@upupming upupming commented Oct 5, 2021

related to PicGo/PicGo-Core#103

We need to wait picgo core's update (merging PicGo/PicGo-Core#102) before merging this PR.

@upupming
Copy link
Contributor Author

upupming commented Oct 5, 2021

I find another problem, TS only treat .d.ts files with no import as ambient declarations, see more at: https://www.typescriptlang.org/docs/handbook/modules.html#ambient-modules and:

image

So the following code will not working:

image

I will fix this problem too.

Update: Done

@upupming
Copy link
Contributor Author

upupming commented Oct 5, 2021

@Molunerfinn I have tested locally using yarn link, once PicGo/PicGo-Core#102 is merged, we can just update the picgo version in package.json and merge this PR.

@Molunerfinn
Copy link
Owner

I have updated the electron version & made some changes. Close now

@Molunerfinn Molunerfinn closed this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants