Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reset (forgot) password auth workflow #187

Merged
merged 5 commits into from
Nov 30, 2023
Merged

feat: Reset (forgot) password auth workflow #187

merged 5 commits into from
Nov 30, 2023

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Nov 27, 2023

Summary:
Reset (forgot) password auth workflow
Closes #141
Related to #188

image

Testing tips:

  • Log out if logged in
  • From the Login screen click on Forgot your password? Reset Here.. You should then be redirected to the password resetting screen
  • Type your registered email and submit
  • Reset your email by following the instructions on the email you received
  • Log in with your new password

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y requested a review from qcdyx November 27, 2023 19:25
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-187-cijz8dc2.web.app

@cka-y
Copy link
Contributor Author

cka-y commented Nov 27, 2023

Needs #164 to be merged first

@cka-y cka-y changed the title feat: reset password feat: Reset (forgot) password auth workflow Nov 29, 2023
@cka-y cka-y marked this pull request as ready for review November 29, 2023 21:10
Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez
Copy link
Member

Nicely done! 💪
One observation: It might not be part of the original issue, but we need to add a reCaptcha component to avoid spam behavior. I'm OK if we create a different issue and merge this as it is.

@@ -0,0 +1,31 @@

describe('Reset Password Screen', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@cka-y cka-y requested review from davidgamez and qcdyx November 30, 2023 16:45
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cka-y cka-y merged commit 2f17199 into main Nov 30, 2023
@cka-y cka-y deleted the feat/141 branch November 30, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset (forgot) password auth workflow
3 participants