feat: flex - overlapping_zone_and_pickup_drop_off_window
#1934
Conversation
cka-y
changed the title
overlapping_zone_and_pickup_drop_off_window
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 7e68a93 📊 Notices ComparisonNew Errors (2 out of 1788 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1788 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
Question: Reference: |
|
@tzujenchanmbd Looks like it based on this section of the code logic: https://github.com/MobilityData/gtfs-validator/pull/1934/files#diff-b5ede17dc903104fb8f7b10cca19398d1aca60d22cc21a204f544028ba670ae9R63 cc @davidgamez |
|
Oh wait, now I see @tzujenchanmbd was right here - cc @davidgamez I don't see any logic that checks for same pickup and drop_off type, only that the windows overlap |
|
Yes @tzujenchanmbd I missed the pick-up/drop-off type check. Should it be added to the fields displayed in the notice details section or is it ok to omit as there's already 9 fields? |
|
@cka-y Since there are already 9 fields, I think we don't need to display the pickup/drop_off_type fields. We can just mention in the description like "Two entities in stop_times.txt with the same trip_id have the same pickup_type or drop_off_type, overlapping pickup/drop-off windows, and overlapping zones in locations.geojson." |
|
@tzujenchanmbd what should be the behaviour if both pickup/drop-off types are omitted? |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 5248c20 📊 Notices ComparisonNew Errors (1 out of 1792 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1792 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
@cka-y Empty is considered equivalent to a value of 0. In other words, when the pickup_type (or drop_off_type) of two entities has the following combinations, the validator should proceed with further checks: [empty, empty] |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 8e05e00 📊 Notices ComparisonNew Errors (2 out of 1792 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1792 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Summary
This PR addresses overlapping geometries and pickup/drop off windows.
Expected Behavior
The pull request ensures overlapping geometries are flagged and appropriate notices are generated during validation. Below are the detailed results for the relevant feeds determined from the :
1. For mdb-2160
The validation identifies overlapping geometries between
area_1082andarea_897.Example screenshot:
Zoomed geometry view:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything