Add personality quirks for re-educated personnel

Introduced a chance for re-educated personnel to gain personality quirks. Made personality quirk generation configurable via the static `PERSONALITY_QUIRK_CHANCE` field for better control. Also exposed `generatePersonalityQuirk` for broader use within the campaign logic.

MekHQ/src/mekhq/campaign/personnel/education/EducationController.java

@@ -40,8 +40,12 @@
 import java.util.*;
 
 import static megamek.common.Compute.d6;
+import static megamek.common.Compute.randomInt;
 import static mekhq.campaign.personnel.SkillType.EXP_REGULAR;
 import static mekhq.campaign.personnel.SkillType.EXP_VETERAN;
+import static mekhq.campaign.randomEvents.personalities.PersonalityController.PERSONALITY_QUIRK_CHANCE;
+import static mekhq.campaign.randomEvents.personalities.PersonalityController.generatePersonalityQuirk;
+import static mekhq.campaign.randomEvents.personalities.PersonalityController.writeDescription;
 
 /**
  * The EducationController class is responsible for managing the education
@@ -1488,6 +1492,14 @@ private static void processGraduation(Campaign campaign, Person person, Academy
                 person.setOriginFaction(campaign.getFaction());
             }
 
+            // People coming out of re-education camps have a chance to become a little weird
+            if (person.getPersonalityQuirk().isNone()) {
+                if (randomInt(PERSONALITY_QUIRK_CHANCE / 2) == 0) {
+                    person.setPersonalityQuirk(generatePersonalityQuirk());
+                    writeDescription(person);
+                }
+            }
+
             // brainwashed personnel should have higher than average loyalty, so they roll
             // 4d6 and drop the lowest roll
             List<Integer> rolls = new ArrayList<>();

MekHQ/src/mekhq/campaign/randomEvents/personalities/PersonalityController.java

@@ -29,10 +29,13 @@
 import java.util.Objects;
 import java.util.Random;
 
+import static megamek.common.Compute.d6;
 import static megamek.common.Compute.randomInt;
 import static mekhq.campaign.randomEvents.personalities.enums.Intelligence.*;
 
 public class PersonalityController {
+    public static int PERSONALITY_QUIRK_CHANCE = 10;
+
     /**
      * Generates a personality for the given person. The method assigns various personality traits,
      * intelligence, and potential quirks to the person.
@@ -52,14 +55,14 @@ public static void generatePersonality(Person person) {
         for (int table = 0; table < 4; table++) {
             // we only want a 1 in 6 chance of getting a personality trait, per table
             // this prevents trait bloat and helps reduce repetitiveness
-            if (randomInt(6) == 0) {
+            if (d6() == 1) {
                 setPersonalityTrait(person, table, randomInt(26));
             }
         }
 
         // we only want 1 in 10 persons to have a quirk,
         // as these helps reduce repetitiveness and keeps them unique
-        if (randomInt(10) == 0) {
+        if (randomInt(PERSONALITY_QUIRK_CHANCE) == 0) {
             person.setPersonalityQuirk(generatePersonalityQuirk());
         }
 
@@ -178,7 +181,7 @@ private static List<String> getTraitDescriptions(Person person) {
     /**
      * @return a random personality quirk for a person.
      */
-    private static PersonalityQuirk generatePersonalityQuirk() {
+    public static PersonalityQuirk generatePersonalityQuirk() {
         Random random = new Random();
         PersonalityQuirk[] values = PersonalityQuirk.values();