Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.7: Remove unneeded namespacing in header files #1780

Merged
merged 4 commits into from
Jul 20, 2018
Merged

Backport 2.7: Remove unneeded namespacing in header files #1780

merged 4 commits into from
Jul 20, 2018

Conversation

RonEld
Copy link
Contributor

@RonEld RonEld commented Jun 24, 2018

Description

Backport of #921 to mbedtls-2.7

Status

READY

Ron Eldor added 2 commits June 24, 2018 17:23
Remove unneeded namesapcing in header files
df9b93e 
Remove the `mbedtls` namesapcing in the `#include` in header files
Resolves issue Mbed-TLS#857
Fix typo in ChangeLog
612a600 
Fix typo in ChangeLog discovered in PR review
@RonEld RonEld added bug mbed TLS team needs-review Every commit must be reviewed by at least two team members, labels Jun 24, 2018
@RonEld RonEld mentioned this pull request Jun 24, 2018
Merged
@simonbutcher simonbutcher changed the title Backport 2.7: Remove unneeded namesapcing in header files Backport 2.7: Remove unneeded namespacing in header files Jun 29, 2018
@simonbutcher
Copy link
Contributor

retest

@simonbutcher simonbutcher added needs-ci Needs to pass CI tests needs-work and removed needs-review Every commit must be reviewed by at least two team members, labels Jul 5, 2018
Ron Eldor added 2 commits July 5, 2018 14:53
Revert changes in the configs folder
47c8fce 
Revert the changes in the `configs` folder to
align with the `README.txt` file.
Remove the namespacing from config-no-entropy.h
0f9a5f1 
Remove the `mbedtls` namespacing from the `config-no-entropy.h` file,
as it is being imported to the include folder.
@RonEld
Copy link
Contributor Author

RonEld commented Jul 5, 2018

@andresag01 The main PAR has been reviewed and approved.
I have cherry-picked the relevant fixes

@RonEld RonEld added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Jul 5, 2018
hanno-becker
hanno-becker approved these changes Jul 11, 2018
View reviewed changes
Copy link

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RonEld RonEld removed the needs-review Every commit must be reviewed by at least two team members, label Jul 11, 2018
@simonbutcher simonbutcher added approved Design and code approved - may be waiting for CI or backports and removed needs-ci Needs to pass CI tests labels Jul 16, 2018
@simonbutcher simonbutcher merged commit 0f9a5f1 into Mbed-TLS:mbedtls-2.7 Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresag01 andresag01 andresag01 approved these changes

@hanno-becker hanno-becker hanno-becker approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RonEld @simonbutcher @andresag01 @hanno-becker