Skip to content

Commit

Permalink
Code cleanup (#1697)
Browse files Browse the repository at this point in the history
  • Loading branch information
akshaysonvane authored and aebadirad committed Dec 18, 2018
1 parent 116c907 commit 45a4f99
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ public HubConfigImpl() {

public void createProject(String projectDirString) {
hubProject.createProject(projectDirString);
// initializeApplicationConfigurations();
}

public String getHost() { return appConfig.getHost(); }
Expand Down Expand Up @@ -1620,13 +1619,6 @@ public DatabaseClient newModulesDbClient() {
return this.DHFVersion;
}


/* this method takes care of setting app config and other non-injected dependencies */
public void initializeApplicationConfigurations() {
hydrateAppConfigs(environment);
hydrateConfigs();
}

private Map<String, String> getCustomTokens() {
AppConfig appConfig = getAppConfig();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,17 +98,7 @@ public Project initializeProject(@PathVariable int projectId, @RequestBody JsonN
om.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
try {
hubConfig = om.readerForUpdating(hubConfig).readValue(hubConfigDelta);

// TODO: Is this needed anymore?
// AppConfig appConfig = this.hubConfig.getAppConfig();
// if (hubConfigDelta.get("host") != null) {
// appConfig.setHost(hubConfigDelta.get("host").asText());
// }
// if (hubConfigDelta.get("name") != null) {
// appConfig.setName(hubConfigDelta.get("name").asText());
// }

this.hubConfig.createProject(project.path);
hubConfig.createProject(project.path);
dataHub.initProject();
return project;
} catch (Exception e) {
Expand Down

0 comments on commit 45a4f99

Please sign in to comment.