Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Commit

Permalink
Drop v17 builds which are just broken in prebuild for now
Browse files Browse the repository at this point in the history
  • Loading branch information
MadLittleMods committed Mar 3, 2022
1 parent cfdb244 commit 2b64fee
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@ jobs:
node-version: ${{ matrix.node }}
architecture: ${{ matrix.arch }}

# FIXME: Install latest v8 once
# https://github.com/actions/setup-node/issues/411#issuecomment-1025543081
# is fixed.
#
# Even though we install a new version of node-gyp locally in
# the project, the CI always seems to use the npm bundled version of
# node-gyp. Even following the instructions from the docs, I could get it working
# on all other platforms except for Windows and npm@6, see
# - https://github.com/nodejs/node-gyp/blob/245cd5bbe4441d4f05e88f2fa20a86425419b6af/docs/Updating-npm-bundled-node-gyp.md
# - https://github.com/nodejs/node-gyp/blob/245cd5bbe4441d4f05e88f2fa20a86425419b6af/docs/Force-npm-to-use-global-node-gyp.md
- name: 'Install npm@^8 to get a more up to date bundled node-gyp'
run: npm install --global [email protected]

Expand Down
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
"lint": "eslint **/*.js",
"validate": "npm run lint && npm test",
"test": "jasmine ./test/test.js",
"prebuild": "prebuild --all --strip --verbose",
"prebuild": "npm run prebuild-node && npm run prebuild-electron",
"prebuild-node": "prebuild --force --strip --verbose -t 12.0.0 -t 14.0.0 -t 16.0.0",
"prebuild-electron": "prebuild --force --strip --verbose -r electron -t 13.0.0 -t 14.0.0 -t 15.0.0 -t 16.0.0",
"prebuild-upload": "prebuild --upload-all",
"rebuild": "node-gyp rebuild"
},
Expand Down

0 comments on commit 2b64fee

Please sign in to comment.