This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drop v17 builds which are just broken in prebuild for now
Copy solution from serialport/node-serialport#2356 See prebuild/prebuild#284
- Loading branch information
1 parent
cfdb244
commit 2b64fee
Showing
2 changed files
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,16 @@ jobs: | |
node-version: ${{ matrix.node }} | ||
architecture: ${{ matrix.arch }} | ||
|
||
# FIXME: Install latest v8 once | ||
# https://github.com/actions/setup-node/issues/411#issuecomment-1025543081 | ||
# is fixed. | ||
# | ||
# Even though we install a new version of node-gyp locally in | ||
# the project, the CI always seems to use the npm bundled version of | ||
# node-gyp. Even following the instructions from the docs, I could get it working | ||
# on all other platforms except for Windows and npm@6, see | ||
# - https://github.com/nodejs/node-gyp/blob/245cd5bbe4441d4f05e88f2fa20a86425419b6af/docs/Updating-npm-bundled-node-gyp.md | ||
# - https://github.com/nodejs/node-gyp/blob/245cd5bbe4441d4f05e88f2fa20a86425419b6af/docs/Force-npm-to-use-global-node-gyp.md | ||
- name: 'Install npm@^8 to get a more up to date bundled node-gyp' | ||
run: npm install --global [email protected] | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters