Skip to content

feat: support hex color with # #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased
<!-- Add all new changes here. They will be moved under a version at release -->
* `FIX` cannot debug in Linux due to lua-debug expecting host process to have lua54 symbols available
* `FIX` support hex color codes with `#` in `textDocument/documentColor`

## 3.14.0
`2025-4-7`
Expand Down
26 changes: 22 additions & 4 deletions script/core/color.lua
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,21 @@ local files = require "files"
local guide = require "parser.guide"

local colorPattern = string.rep('%x', 8)
local hex6Pattern = string.format("^#%s", string.rep('%x', 6))
---@param source parser.object
---@return boolean
local function isColor(source)
---@type string
local text = source[1]
if text:len() ~= 8 then
return false
if text:len() == 8 then
return text:match(colorPattern)
end
return text:match(colorPattern)

if text:len() == 7 then
return text:match(hex6Pattern)
end

return false
end


Expand All @@ -25,6 +31,16 @@ local function textToColor(colorText)
}
end

---@param colorText string
---@return Color
local function hexTextToColor(colorText)
return {
alpha = 255,
red = tonumber(colorText:sub(2, 3), 16) / 255,
green = tonumber(colorText:sub(4, 5), 16) / 255,
blue = tonumber(colorText:sub(6, 7), 16) / 255,
}
end

---@param color Color
---@return string
Expand Down Expand Up @@ -63,10 +79,12 @@ local function colors(uri)
---@type string
local colorText = source[1]

local color = colorText:match(colorPattern) and textToColor(colorText) or hexTextToColor(colorText)

colorValues[#colorValues+1] = {
start = source.start + 1,
finish = source.finish - 1,
color = textToColor(colorText)
color = color
}
end
end)
Expand Down
Loading