Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update Speech Recognition example (with learning_rate) #1272

Closed
wants to merge 4 commits into from

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Apr 4, 2022

What does this PR do?

Addresses #1112 to add learning_rate to the SpeechRecognition constructor.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #1272 (6ee6570) into master (3c74081) will increase coverage by 8.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
+ Coverage   81.16%   89.66%   +8.50%     
==========================================
  Files         284      284              
  Lines       12745    12745              
==========================================
+ Hits        10344    11428    +1084     
+ Misses       2401     1317    -1084     
Flag Coverage Δ
unittests 89.66% <ø> (+8.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/io/input_transform.py 70.95% <0.00%> (+0.25%) ⬆️
flash/core/data/data_module.py 94.16% <0.00%> (+0.36%) ⬆️
flash/text/question_answering/model.py 85.13% <0.00%> (+0.67%) ⬆️
flash/core/data/utilities/classification.py 98.24% <0.00%> (+1.16%) ⬆️
flash/core/data/properties.py 90.62% <0.00%> (+1.56%) ⬆️
flash/core/data/transforms.py 96.49% <0.00%> (+1.75%) ⬆️
flash/image/segmentation/data.py 100.00% <0.00%> (+2.00%) ⬆️
flash/image/classification/data.py 97.87% <0.00%> (+2.83%) ⬆️
flash/core/adapter.py 97.14% <0.00%> (+2.85%) ⬆️
flash/image/classification/input_transform.py 84.37% <0.00%> (+3.12%) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c74081...6ee6570. Read the comment docs.

@ethanwharris ethanwharris added this to the 0.7.x milestone Apr 4, 2022
@ethanwharris ethanwharris added the documentation Improvements or additions to documentation label Apr 4, 2022
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris
Copy link
Collaborator

Closing in favour of #1275

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants