Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Change LightningLoggerBase to Logger #973

Merged
merged 4 commits into from
May 11, 2023
Merged

🐛 Change LightningLoggerBase to Logger #973

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2c44c2
🐛 Change LightningLoggerBase to Logger
julien-blanchon Feb 6, 2023
f24b60b
🔧 Maintain older version compatibility
julien-blanchon Feb 24, 2023
f114949
Merge branch 'master' into fix-lightningloggerbase
Borda May 11, 2023
ff662f1
Apply suggestions from code review
Borda May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pl_bolts/callbacks/data_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import numpy as np
import torch
from pytorch_lightning import Callback, LightningModule, Trainer
from pytorch_lightning.loggers import LightningLoggerBase, TensorBoardLogger, WandbLogger
from pytorch_lightning.loggers import Logger, TensorBoardLogger, WandbLogger
from pytorch_lightning.utilities import rank_zero_warn
from pytorch_lightning.utilities.apply_func import apply_to_collection
from torch import Tensor, nn
Expand Down Expand Up @@ -97,7 +97,7 @@ def log_histogram(self, tensor: Tensor, name: str) -> None:

logger.experiment.log(data={name: wandb.Histogram(tensor)}, commit=False)

def _is_logger_available(self, logger: LightningLoggerBase) -> bool:
def _is_logger_available(self, logger: Logger) -> bool:
available = True
if not logger:
rank_zero_warn("Cannot log histograms because Trainer has no logger.")
Expand Down