Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding types to some of datamodules #462

Merged
merged 81 commits into from
Jan 20, 2021
Merged

Adding types to some of datamodules #462

Changes from 1 commit
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
34f5f07
Adding types to datamodules
briankosw Dec 18, 2020
2b55b32
Fixing typing imports
briankosw Dec 18, 2020
ac3377d
Removing torchvision.transforms from return typing
briankosw Dec 19, 2020
a4c39c7
Remove more torchvision.transforms typing
briankosw Dec 19, 2020
ffa0cb9
Removing return typing
briankosw Dec 21, 2020
5e6c5d4
Add `None` for optional arguments
briankosw Dec 21, 2020
3a5a0ab
Remove unnecessary import
briankosw Dec 21, 2020
30579ed
Remove unnecessary import
briankosw Dec 21, 2020
5de590c
Merge branch 'types/datamodules' of https://github.com/briankosw/pyto…
briankosw Dec 21, 2020
c675931
Add `None` return type
briankosw Dec 21, 2020
267649c
Add type for torchvision transforms
briankosw Jan 5, 2021
3938fff
Adding types to datamodules
briankosw Dec 18, 2020
cae3f46
Fixing typing imports
briankosw Dec 18, 2020
7af027e
Removing torchvision.transforms from return typing
briankosw Dec 19, 2020
7bec605
Remove more torchvision.transforms typing
briankosw Dec 19, 2020
afbc918
Removing return typing
briankosw Dec 21, 2020
17ce335
Add `None` for optional arguments
briankosw Dec 21, 2020
d09f98d
Remove unnecessary import
briankosw Dec 21, 2020
b61fdc0
Add `None` return type
briankosw Dec 21, 2020
f2f4305
Add type for torchvision transforms
briankosw Jan 5, 2021
cd09554
enable check
Borda Jan 5, 2021
797a9d1
Merge branch 'types/datamodules' of https://github.com/briankosw/pyto…
briankosw Jan 6, 2021
0fcd186
Adding types to datamodules
briankosw Dec 18, 2020
a430696
Fixing typing imports
briankosw Dec 18, 2020
a84551e
Removing torchvision.transforms from return typing
briankosw Dec 19, 2020
685162c
Remove more torchvision.transforms typing
briankosw Dec 19, 2020
0140837
Removing return typing
briankosw Dec 21, 2020
a6b8d4a
Add `None` for optional arguments
briankosw Dec 21, 2020
de35a55
Remove unnecessary import
briankosw Dec 21, 2020
f521b79
Add `None` return type
briankosw Dec 21, 2020
fa0d271
Add type for torchvision transforms
briankosw Jan 5, 2021
0bc9f7b
Adding types to datamodules
briankosw Dec 18, 2020
05fcef2
Fixing typing imports
briankosw Dec 18, 2020
d92604b
Removing torchvision.transforms from return typing
briankosw Dec 19, 2020
a9c641b
Removing return typing
briankosw Dec 21, 2020
314329c
Add `None` return type
briankosw Dec 21, 2020
14ea6b7
enable check
Borda Jan 5, 2021
e97332c
Merge branch 'types/datamodules' of https://github.com/briankosw/pyto…
briankosw Jan 12, 2021
8a7c6f1
Adding types to datamodules
briankosw Dec 18, 2020
3b0ee3c
Fixing typing imports
briankosw Dec 18, 2020
3d1c9a1
Removing torchvision.transforms from return typing
briankosw Dec 19, 2020
6cac909
Remove more torchvision.transforms typing
briankosw Dec 19, 2020
c1ea0fb
Removing return typing
briankosw Dec 21, 2020
c04caab
Add `None` for optional arguments
briankosw Dec 21, 2020
5b6bf64
Remove unnecessary import
briankosw Dec 21, 2020
7ce736d
Add `None` return type
briankosw Dec 21, 2020
7309ade
Add type for torchvision transforms
briankosw Jan 5, 2021
cc154a7
Adding types to datamodules
briankosw Dec 18, 2020
cff7330
Fixing typing imports
briankosw Dec 18, 2020
3bbc189
Removing torchvision.transforms from return typing
briankosw Dec 19, 2020
5b2401b
Removing return typing
briankosw Dec 21, 2020
7eb32b8
Add `None` return type
briankosw Dec 21, 2020
47cca32
enable check
Borda Jan 5, 2021
52e4811
Adding types to datamodules
briankosw Dec 18, 2020
64f871e
Fixing typing imports
briankosw Dec 18, 2020
bf6ee1c
Removing torchvision.transforms from return typing
briankosw Dec 19, 2020
b5c6dcc
Removing return typing
briankosw Dec 21, 2020
984a962
Add `None` return type
briankosw Dec 21, 2020
7894471
Adding types to datamodules
briankosw Dec 18, 2020
3443883
Fixing typing imports
briankosw Dec 18, 2020
51f8f16
Removing torchvision.transforms from return typing
briankosw Dec 19, 2020
3062dba
Removing return typing
briankosw Dec 21, 2020
53ebe33
Add `None` return type
briankosw Dec 21, 2020
ec068e4
Merge branch 'types/datamodules' of https://github.com/briankosw/pyto…
briankosw Jan 12, 2021
c15efdb
Fix rebasing mistakes
briankosw Jan 12, 2021
7bc0c37
Fix flake8
briankosw Jan 12, 2021
a5f3e4f
Fix yapf format
briankosw Jan 12, 2021
e0c05a2
Merge branch 'master' into types/datamodules
Borda Jan 18, 2021
bd97183
Merge branch 'master' into briankosw-types/datamodules
akihironitta Jan 19, 2021
b9c910d
Add types and skip mypy checks on some files
akihironitta Jan 20, 2021
9e222d0
Fix setup.cfg
akihironitta Jan 20, 2021
0c54fdd
Add missing import
akihironitta Jan 20, 2021
8b2e196
isort
akihironitta Jan 20, 2021
9c5dd5c
yapf
akihironitta Jan 20, 2021
c6c97e1
mypy please...
akihironitta Jan 20, 2021
4ac8a5b
Please be quiet mypy and flake8
akihironitta Jan 20, 2021
e847ead
yapf...
akihironitta Jan 20, 2021
1839438
Disable all of yapf, flake8, and mypy
akihironitta Jan 20, 2021
097df6d
Use Callable
akihironitta Jan 20, 2021
9e00c5d
Use Callable
akihironitta Jan 20, 2021
af563a5
Add missing import
akihironitta Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary import
  • Loading branch information
@briankosw
briankosw committed Dec 21, 2020
commit 3a5a0ab24859431edb150df1934ff74b6b2e3b9f
1 change: 0 additions & 1 deletion pl_bolts/datamodules/vision_datamodule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from pytorch_lightning import LightningDataModule
from torch.utils.data import DataLoader, Dataset, random_split

from pl_bolts.utils import _TORCHVISION_AVAILABLE
from pl_bolts.utils.warnings import warn_missing_pkg


Expand Down