Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYOL: add lr scheduler #148

Merged
merged 1 commit into from
Aug 5, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pl_bolts/models/self_supervised/byol/byol_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from pl_bolts.datamodules import CIFAR10DataModule, STL10DataModule, ImagenetDataModule
from pl_bolts.models.self_supervised.simclr.simclr_transforms import SimCLREvalDataTransform, SimCLRTrainDataTransform
from pl_bolts.optimizers.layer_adaptive_scaling import LARS
from pl_bolts.optimizers.lr_scheduler import LinearWarmupCosineAnnealingLR
from pl_bolts.models.self_supervised.byol.models import SiameseArm
from pl_bolts.callbacks.self_supervised import BYOLMAWeightUpdate

Expand All @@ -14,7 +15,7 @@ class BYOL(pl.LightningModule):
def __init__(self,
datamodule: pl.LightningDataModule = None,
data_dir: str = './',
learning_rate: float = 0.00006,
learning_rate: float = 0.2,
weight_decay: float = 0.0005,
input_height: int = 32,
batch_size: int = 32,
Expand Down Expand Up @@ -153,9 +154,9 @@ def validation_step(self, batch, batch_idx):
return result

def configure_optimizers(self):
optimizer = LARS(self.parameters(), lr=self.hparams.learning_rate)
# TODO: add scheduler - cosine decay
return optimizer
optimizer = LARS(self.parameters(), lr=self.hparams.learning_rate, weight_decay=0.000015)
scheduler = LinearWarmupCosineAnnealingLR(optimizer, warmup_epochs=10, max_epochs=1000)
return [optimizer], [scheduler]

@staticmethod
def add_model_specific_args(parent_parser):
Expand Down