-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move get_active_optimizers to utilities #9581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
refactor/get-active-optimizers-2
branch
from
September 17, 2021 12:16
6839a98
to
e22e590
Compare
awaelchli
commented
Sep 23, 2021
awaelchli
commented
Sep 23, 2021
carmocca
reviewed
Sep 23, 2021
awaelchli
requested review from
Borda,
justusschock,
kaushikb11,
tchaton and
williamFalcon
as code owners
September 23, 2021 15:54
Codecov Report
@@ Coverage Diff @@
## master #9581 +/- ##
======================================
Coverage 93% 93%
======================================
Files 179 179
Lines 15329 15331 +2
======================================
+ Hits 14222 14224 +2
Misses 1107 1107 |
carmocca
approved these changes
Sep 23, 2021
tchaton
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Borda
reviewed
Sep 24, 2021
ananthsub
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #7938
Moves the
get_active_optimizers()
method to the utilities. It is currently used by multiple loops and after #9490 only in one loop, but there is no reason why it should be a method on any of the loops as loops don't own optimizers, nor should loop customization make any assumptions which loop has this method.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃