Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move get_active_optimizers to utilities #9581

Merged
merged 10 commits into from
Sep 25, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 17, 2021

What does this PR do?

Part of #7938

Moves the get_active_optimizers() method to the utilities. It is currently used by multiple loops and after #9490 only in one loop, but there is no reason why it should be a method on any of the loops as loops don't own optimizers, nor should loop customization make any assumptions which loop has this method.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added this to the v1.5 milestone Sep 17, 2021
@awaelchli awaelchli added the design Includes a design discussion label Sep 17, 2021
@awaelchli awaelchli force-pushed the refactor/get-active-optimizers-2 branch from 6839a98 to e22e590 Compare September 17, 2021 12:16
@awaelchli awaelchli marked this pull request as ready for review September 23, 2021 15:54
@carmocca carmocca mentioned this pull request Sep 23, 2021
9 tasks
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #9581 (2f8d4b9) into master (2b2537d) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9581   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     179           
  Lines       15329   15331    +2     
======================================
+ Hits        14222   14224    +2     
  Misses       1107    1107           

@mergify mergify bot removed the has conflicts label Sep 23, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 24, 2021
@mergify mergify bot removed the has conflicts label Sep 25, 2021
@awaelchli awaelchli merged commit 5395ceb into master Sep 25, 2021
@awaelchli awaelchli deleted the refactor/get-active-optimizers-2 branch September 25, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants