Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split callbacks #849

Merged
merged 28 commits into from
Feb 23, 2020
Merged

Split callbacks #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
bf9b67c
add .vscode in .gitignore
hadim Feb 16, 2020
579c99d
Split callbacks in individual files + add a property to Callback for…
hadim Feb 16, 2020
2558718
formatting
hadim Feb 16, 2020
df8a065
Add a conda env file for quick and easy env setup to develop on PL
hadim Feb 17, 2020
960c451
Adress comments
hadim Feb 17, 2020
0bd56b8
add fix to kth_best_model
hadim Feb 18, 2020
fc42428
add some typing to callbacks
hadim Feb 18, 2020
d22fc7e
fix typo
hadim Feb 18, 2020
72d5449
add autopep8 config to pyproject.toml
hadim Feb 18, 2020
e99e348
format again
hadim Feb 18, 2020
6fcbe84
format
hadim Feb 18, 2020
d51cdf3
fix toml
hadim Feb 18, 2020
875ff3a
fix toml again
hadim Feb 18, 2020
d67db86
consistent max line length in all config files
hadim Feb 18, 2020
4d0955b
remove conda env file
hadim Feb 19, 2020
33abad6
Update pytorch_lightning/callbacks/early_stopping.py
hadim Feb 19, 2020
6eae113
Update pytorch_lightning/callbacks/model_checkpoint.py
hadim Feb 19, 2020
9331417
docstring
hadim Feb 19, 2020
8234709
Update pytorch_lightning/callbacks/model_checkpoint.py
hadim Feb 19, 2020
5561188
Update pytorch_lightning/callbacks/model_checkpoint.py
hadim Feb 19, 2020
9931d7f
fix logic error
hadim Feb 19, 2020
2c3746e
format
hadim Feb 19, 2020
fcf3cae
simplify if/else
Borda Feb 19, 2020
b3757cf
format
hadim Feb 19, 2020
275673b
fix linting issue in changelog
hadim Feb 19, 2020
5a5d80f
edit changelog about new callback mechanism
hadim Feb 19, 2020
6b61f43
fix remaining formating issue on CHANGELOG
hadim Feb 19, 2020
2244f8c
remove lambda function because it's compatible with pickle (used duri…
hadim Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ model_weights/
app/models/
pip-wheel-metadata/
lightning_logs/

.vscode/

# Test-tube
test_tube_logs/
Expand Down
2 changes: 2 additions & 0 deletions .markdownlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
MD013: false # headers with the same names
MD024: false # line length
2 changes: 1 addition & 1 deletion .pep8speaks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ scanner:
linter: pycodestyle # Other option is flake8

pycodestyle: # Same as scanner.linter value. Other option is flake8
max-line-length: 100 # Default is 79 in PEP 8
max-line-length: 120 # Default is 79 in PEP 8
hadim marked this conversation as resolved.
Show resolved Hide resolved
ignore: # Errors and warnings to ignore
- W504 # line break after binary operator
- E402 # module level import not at top of file
Expand Down
Loading