-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LightningCLI(save_config_overwrite=False|True)
#8059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
feature
Is an improvement or enhancement
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
labels
Jun 21, 2021
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
June 21, 2021 11:09
Codecov Report
@@ Coverage Diff @@
## master #8059 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 210 210
Lines 13579 13581 +2
======================================
- Hits 12452 12416 -36
- Misses 1127 1165 +38 |
carmocca
changed the title
LightningCLI exist_ok
Add Jun 21, 2021
LightningCLI(save_config_exist_ok=False|True)
awaelchli
approved these changes
Jun 21, 2021
carmocca
changed the title
Add
Add Jun 21, 2021
LightningCLI(save_config_exist_ok=False|True)
LightningCLI(save_config_overwrite=False|True)
Borda
approved these changes
Jun 21, 2021
mauvilsa
approved these changes
Jun 21, 2021
justusschock
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
overwrite
toSaveConfigCallback
+ plumbing for itImprove error message
Add test
cc: @mauvilsa
Before submitting
PR review