Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker/nvidia #7109

Merged
merged 7 commits into from
Apr 27, 2021
Merged

Docker/nvidia #7109

merged 7 commits into from
Apr 27, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 19, 2021

What does this PR do?

ngc requires #6999 in #7126

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the feature Is an improvement or enhancement label Apr 19, 2021
@Borda Borda added this to the v1.3 milestone Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #7109 (712e2da) into master (832a03a) will decrease coverage by 8%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #7109     +/-   ##
========================================
- Coverage      92%     85%     -8%     
========================================
  Files         196     197      +1     
  Lines       12571   14468   +1897     
========================================
+ Hits        11594   12227    +633     
- Misses        977    2241   +1264     

@Borda Borda marked this pull request as ready for review April 22, 2021 22:25
@Borda Borda requested a review from tchaton as a code owner April 22, 2021 22:25
@Borda Borda enabled auto-merge (squash) April 22, 2021 22:26
dockers/README.md Outdated Show resolved Hide resolved
Co-authored-by: Carlos Mocholí <[email protected]>
@Borda Borda added the ready PRs ready to be merged label Apr 25, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit a153c15 into master Apr 27, 2021
@Borda Borda deleted the docker/nvidia branch April 27, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants