Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove evaluation loop legacy dict returns for *_epoch_end hooks #6973

Merged
merged 7 commits into from
Apr 13, 2021
Merged

Remove evaluation loop legacy dict returns for *_epoch_end hooks #6973

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b956e65
Update evaluation_loop.py
ananthsub Apr 12, 2021
b684e84
Update test_eval_loop_flow.py
ananthsub Apr 12, 2021
79299ec
remove unused
ananthsub Apr 12, 2021
34849d1
Remove legacy code
carmocca Apr 13, 2021
dfa0841
Merge branch 'master' into rm-deprecate-warning-eval-loop
carmocca Apr 13, 2021
0e7dbc3
pep8
carmocca Apr 13, 2021
f7a0679
Update CHANGELOG.md
ananthsub Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions pytorch_lightning/trainer/evaluation_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,6 @@ def __run_eval_epoch_end(self, num_dataloaders):

# capture logging
self.trainer.logger_connector.cache_logged_metrics()
# depre warning
if eval_results is not None and user_reduced:
step = 'testing_epoch_end' if self.trainer.testing else 'validation_epoch_end'
self.warning_cache.warn(
f'The {step} should not return anything as of 9.1.'
' To log, use self.log(...) or self.write(...) directly in the LightningModule'
)

if not isinstance(eval_results, list):
ananthsub marked this conversation as resolved.
Show resolved Hide resolved
eval_results = [eval_results]
Expand Down