Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Horovod] Fix Reduce for Horovod #6585

Closed
wants to merge 12 commits into from
Closed

[Horovod] Fix Reduce for Horovod #6585

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2505ccc
bug fix
amogkam Mar 18, 2021
6ccfd68
Update pytorch_lightning/plugins/training_type/horovod.py
amogkam Mar 19, 2021
e9d9c08
try add test
amogkam Mar 19, 2021
cf988b9
Merge branch 'horovod-reduce' of github.com:amogkam/pytorch-lightning…
amogkam Mar 19, 2021
d1790cd
Apply suggestions from code review
Borda Mar 25, 2021
6b9c62f
Reuse code
carmocca Mar 25, 2021
4e28fd2
Merge branch 'master' into horovod-reduce
carmocca Mar 25, 2021
1b05074
Avoid name conflict
carmocca Mar 25, 2021
29fc2e8
Forgot argument
carmocca Mar 25, 2021
cae1419
Minor changes
carmocca Mar 25, 2021
3b293a7
Merge branch 'master' into horovod-reduce
carmocca Apr 19, 2021
d22297d
Bad merge
carmocca Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bug fix
  • Loading branch information
@amogkam
amogkam committed Mar 18, 2021
commit 2505ccc411f3eae536f2334eb25e47a74cfdbc9d
2 changes: 1 addition & 1 deletion pytorch_lightning/plugins/training_type/horovod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def reduce(self, tensor, group: Optional[Any] = None, reduce_op: Optional[Union[

if reduce_op in (None, "avg", "mean"):
reduce_op = hvd.Average
elif reduce_op == "sum":
elif reduce_op == "sum" or reduce_op == ReduceOp.SUM:
reduce_op = hvd.Sum
else:
raise ValueError(f"unrecognized `reduce_op`: {reduce_op}")
Expand Down