-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up unused distributed sampler logic in trainer #5975
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5975 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 170 170
Lines 11805 11789 -16
======================================
- Hits 10674 10640 -34
- Misses 1131 1149 +18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted code is the best code 💃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleaning !
https://twitter.com/fishnets88/status/1360865122969923584?s=19 |
What does this PR do?
Follow up to #5743
The kwargs needed for the distributed sampler are provided by the parallel plugins. The unused logic in the trainer is obsolete.
We keep the property in the trainer for backward compatibility and ease of access internally, and reference the property in the training type plugin.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃