Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up unused distributed sampler logic in trainer #5975

Merged
merged 9 commits into from
Feb 15, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 15, 2021

What does this PR do?

Follow up to #5743
The kwargs needed for the distributed sampler are provided by the parallel plugins. The unused logic in the trainer is obsolete.
We keep the property in the trainer for backward compatibility and ease of access internally, and reference the property in the training type plugin.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #5975 (f1d0405) into master (4f63942) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5975   +/-   ##
======================================
- Coverage      90%     90%   -0%     
======================================
  Files         170     170           
  Lines       11805   11789   -16     
======================================
- Hits        10674   10640   -34     
- Misses       1131    1149   +18     

@Borda Borda added this to the 1.2 milestone Feb 15, 2021
@Borda Borda enabled auto-merge (squash) February 15, 2021 07:55
@Borda Borda added the ready PRs ready to be merged label Feb 15, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted code is the best code 💃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleaning !

@Borda
Copy link
Member

Borda commented Feb 15, 2021

Deleted code is the best code 💃

https://twitter.com/fishnets88/status/1360865122969923584?s=19

@Borda Borda merged commit d422ef2 into master Feb 15, 2021
@Borda Borda deleted the refactor/sampler-kwargs branch February 15, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants