Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where tuner would not tune lr if also tuning batch_size #4688

Merged
merged 7 commits into from
Mar 9, 2021
Merged

fixed bug where tuner would not tune lr if also tuning batch_size #4688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ea4a9a2
fixed bug where tuner would not tune lr if also tuning batch_size
Palzer Nov 15, 2020
e56eff8
added a '+1' to computing the smoothed loss. This maintains the behav…
Palzer Nov 15, 2020
452d0b3
pep8 fix
Palzer Nov 15, 2020
face312
Merge branch 'master' into lr_tuner_fix
tchaton Dec 3, 2020
0d29012
Merge branch 'master' into lr_tuner_fix
carmocca Mar 1, 2021
5163eb4
Merge branch 'master' into lr_tuner_fix
awaelchli Mar 8, 2021
76de8cc
add changelog
awaelchli Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed `Trainer` not resetting `lightning_optimizers` when calling `Trainer.fit()` multiple times ([#6372](https://github.com/PyTorchLightning/pytorch-lightning/pull/6372))


- Fixed an issue where the tuner would not tune the learning rate if also tuning the batch size ([#4688](https://github.com/PyTorchLightning/pytorch-lightning/pull/4688))


## [1.2.2] - 2021-03-02

### Added
Expand Down
4 changes: 2 additions & 2 deletions pytorch_lightning/tuner/lr_finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,11 @@ def on_train_batch_end(self, trainer, pl_module, outputs, batch, batch_idx, data
self.progress_bar.update()

current_loss = trainer.train_loop.running_loss.last().item()
current_step = trainer.global_step + 1 # remove the +1 in 1.0
current_step = trainer.global_step

# Avg loss (loss with momentum) + smoothing
self.avg_loss = self.beta * self.avg_loss + (1 - self.beta) * current_loss
smoothed_loss = self.avg_loss / (1 - self.beta**current_step)
smoothed_loss = self.avg_loss / (1 - self.beta**(current_step + 1))

# Check if we diverging
if self.early_stop_threshold is not None:
Expand Down