Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump python 3.9+ #20413

Merged
merged 14 commits into from
Nov 25, 2024
Merged

bump python 3.9+ #20413

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
060d951
bump python 3.9+
Borda Nov 12, 2024
c11c392
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 12, 2024
b9920bd
--unsafe-fixes
Borda Nov 12, 2024
a35f1fe
contextlib.AbstractContextManager
Borda Nov 12, 2024
7858262
type: ignore[misc]
Borda Nov 12, 2024
7421932
update CI
Borda Nov 12, 2024
cba3391
Merge branch 'master' into bump/python_3.9+
Borda Nov 12, 2024
b373a76
Merge branch 'master' into bump/python_3.9+
Borda Nov 13, 2024
5da2e43
apply fixes
Borda Nov 13, 2024
ce62f96
Merge branch 'master' into bump/python_3.9+
Borda Nov 13, 2024
4f22163
Merge branch 'master' into bump/python_3.9+
Borda Nov 13, 2024
c542968
apply fixes
Borda Nov 13, 2024
392f643
Merge branch 'master' into bump/python_3.9+
lantiga Nov 14, 2024
8f39967
Merge branch 'master' into bump/python_3.9+
Borda Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bump python 3.9+
  • Loading branch information
@Borda
Borda committed Nov 12, 2024
commit 060d951605cc837607e4c4fce2979aca0d208e0d
2 changes: 1 addition & 1 deletion .github/workflows/_legacy-checkpoints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
- uses: actions/setup-python@v5
with:
# Python version here needs to be supported by all PL versions listed in back-compatible-versions.txt.
python-version: 3.8
python-version: "3.9"

- name: Install PL from source
env:
Expand Down
4 changes: 2 additions & 2 deletions docs/source-pytorch/accelerators/tpu_faq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ Unsupported datatype transfer to TPUs?

.. code-block::

File "/usr/local/lib/python3.8/dist-packages/torch_xla/utils/utils.py", line 205, in _for_each_instance_rewrite
File "/usr/local/lib/python3.9/dist-packages/torch_xla/utils/utils.py", line 205, in _for_each_instance_rewrite
v = _for_each_instance_rewrite(result.__dict__[k], select_fn, fn, rwmap)
File "/usr/local/lib/python3.8/dist-packages/torch_xla/utils/utils.py", line 206, in _for_each_instance_rewrite
File "/usr/local/lib/python3.9/dist-packages/torch_xla/utils/utils.py", line 206, in _for_each_instance_rewrite
result.__dict__[k] = v
TypeError: 'mappingproxy' object does not support item assignment

Expand Down
2 changes: 1 addition & 1 deletion docs/source-pytorch/advanced/post_training_quantization.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Installation
Prerequisites
=============

Python version: 3.8, 3.9, 3.10
Python version: 3.9, 3.10

Install Intel® Neural Compressor
================================
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ignore-words-list = "te, compiletime"

[tool.ruff]
line-length = 120
target-version = "py38"
target-version = "py39"
# Exclude a variety of commonly ignored directories.
exclude = [
".git",
Expand Down
3 changes: 1 addition & 2 deletions src/lightning_fabric/__setup__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def _setup_args() -> Dict[str, Any]:
"include_package_data": True,
"zip_safe": False,
"keywords": ["deep learning", "pytorch", "AI"],
"python_requires": ">=3.8",
"python_requires": ">=3.9",
"setup_requires": ["wheel"],
"install_requires": assistant.load_requirements(
_PATH_REQUIREMENTS, unfreeze="none" if _FREEZE_REQUIREMENTS else "all"
Expand Down Expand Up @@ -105,7 +105,6 @@ def _setup_args() -> Dict[str, Any]:
# Specify the Python versions you support here. In particular, ensure
# that you indicate whether you support Python 2, Python 3 or both.
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
3 changes: 1 addition & 2 deletions src/pytorch_lightning/__setup__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def _setup_args() -> Dict[str, Any]:
"long_description_content_type": "text/markdown",
"zip_safe": False,
"keywords": ["deep learning", "pytorch", "AI"],
"python_requires": ">=3.8",
"python_requires": ">=3.9",
"setup_requires": ["wheel"],
# TODO: aggregate pytorch and lite requirements as we include its source code directly in this package.
# this is not a problem yet because lite's base requirements are all included in pytorch's base requirements
Expand All @@ -107,7 +107,6 @@ def _setup_args() -> Dict[str, Any]:
"Operating System :: OS Independent",
# Specify the Python versions you support here.
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
Loading