Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow immutable file upload for wandb logger #20193

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cgebbe
Copy link

@cgebbe cgebbe commented Aug 13, 2024

What does this PR do?

Current Problem

  • given wandblogger with log_models=True and e.g. one ModelCheckpoint with save_top_k=3
  • when finalizing a run
  • then many models will be uploaded to wandb and beforehand copied to a local temporary directory
  • and this copying can easily lead to a full disk space and thus a failed run.

Solution

  • Allow to specify immutable as policy for add_file to prevent copying.

Open questions

  • I didn't add a test, since the wandb logger is a stub and this feels like a very safe modification. Is that okay? Otherwise, what do you suggest?
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20193.org.readthedocs.build/en/20193/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 13, 2024
@cgebbe cgebbe requested a review from ethanwharris as a code owner January 28, 2025 09:44
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (ea59e40) to head (6c022d0).

❗ There is a different number of reports uploaded between BASE (ea59e40) and HEAD (6c022d0). Click for more details.

HEAD has 146 uploads less than BASE
Flag BASE (ea59e40) HEAD (6c022d0)
cpu 59 24
lightning_fabric 10 0
pytest 37 0
python3.9 17 6
lightning 45 18
python3.10 8 3
python3.11 16 6
python3.12.7 18 9
gpu 2 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20193     +/-   ##
=========================================
- Coverage      88%      79%     -9%     
=========================================
  Files         267      264      -3     
  Lines       23380    23326     -54     
=========================================
- Hits        20481    18367   -2114     
- Misses       2899     4959   +2060     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants