-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: pin version in links to external docs [1/n] #19584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
awaelchli,
carmocca,
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
March 6, 2024 20:18
github-actions
bot
added
docs
Documentation related
ci
Continuous Integration
pl
Generic label for PyTorch Lightning package
dependencies
Pull requests that update a dependency file
labels
Mar 6, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19584 +/- ##
========================================
+ Coverage 83% 84% +1%
========================================
Files 424 424
Lines 34910 34910
========================================
+ Hits 28934 29218 +284
+ Misses 5976 5692 -284 |
awaelchli
approved these changes
Mar 6, 2024
Co-authored-by: awaelchli <[email protected]>
Borda
changed the title
docs: ignore link to private repo
docs: pin version in links to external docs
Mar 6, 2024
Borda
changed the title
docs: pin version in links to external docs
docs: pin version in links to external docs [1/n]
Mar 6, 2024
This was referenced Mar 6, 2024
Borda
commented
Mar 18, 2024
github-actions
bot
added
fabric
lightning.fabric.Fabric
app (removed)
Generic label for Lightning App package
labels
Mar 18, 2024
ethanwharris
approved these changes
Mar 19, 2024
justusschock
approved these changes
Mar 19, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
ci
Continuous Integration
dependencies
Pull requests that update a dependency file
docs
Documentation related
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initial version to address #19550 (comment)
basically, at the docs build time it replaces all
stable
with a specific version - latest available at the timeBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19584.org.readthedocs.build/en/19584/
cc @Borda @carmocca @justusschock @awaelchli