Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lightning AI multi-node guide (Trainer) #19530

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 25, 2024

What does this PR do?

Follow up to #19324
The description is the same as in #19324, with only the code snippets and tutorial video changed.

Closes #12143


📚 Documentation preview 📚: https://pytorch-lightning--19530.org.readthedocs.build/en/19530/

cc @Borda

@awaelchli awaelchli added the docs Documentation related label Feb 25, 2024
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 25, 2024
@awaelchli awaelchli added fun Staff contributions outside working hours - to differentiate from the "community" label and removed pl Generic label for PyTorch Lightning package labels Feb 25, 2024
@awaelchli awaelchli added this to the 2.3 milestone Feb 25, 2024
Copy link
Contributor

github-actions bot commented Feb 25, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to docs/source-pytorch/clouds/cluster.rst, docs/source-pytorch/clouds/lightning_ai.rst, docs/source-pytorch/common/index.rst, docs/source-pytorch/common_usecases.rst, docs/source-pytorch/levels/intermediate.rst, docs/source-pytorch/levels/intermediate_level_14.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli requested a review from carmocca February 25, 2024 21:51
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 25, 2024
docs/source-pytorch/clouds/lightning_ai.rst Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Feb 26, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5685611 Triggered Generic High Entropy Secret 403a912 tests/tests_app/utilities/test_login.py View secret
7296313 Triggered Base64 Basic Authentication 403a912 tests/tests_app/utilities/test_login.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mergify mergify bot added the ready PRs ready to be merged label Feb 27, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@lantiga lantiga merged commit abae4c9 into master Feb 28, 2024
23 checks passed
@lantiga lantiga deleted the docs/multi-node-pl branch February 28, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
4 participants