Skip to content

Commit

Permalink
Update removal version of argparse_utils.py from 1.4 to 2.0 for backw…
Browse files Browse the repository at this point in the history
…ards compatibility (#9162)
  • Loading branch information
Tshimanga authored Aug 27, 2021
1 parent e133061 commit 811d37b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Deprecated the `TestTubeLogger` ([#9065](https://github.com/PyTorchLightning/pytorch-lightning/pull/9065))


- Updated deprecation of `argparse_utils.py` from removal in 1.4 to 2.0 ([#9162](https://github.com/PyTorchLightning/pytorch-lightning/pull/9162))



### Removed

- Removed deprecated `metrics` ([#8586](https://github.com/PyTorchLightning/pytorch-lightning/pull/8586/))
Expand Down
2 changes: 1 addition & 1 deletion pytorch_lightning/utilities/argparse_utils.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from pytorch_lightning.utilities import rank_zero_deprecation

rank_zero_deprecation("`argparse_utils` package has been renamed to `argparse` since v1.2 and will be removed in v1.4")
rank_zero_deprecation("`argparse_utils` package has been renamed to `argparse` since v1.2 and will be removed in v2.0")

# for backward compatibility with old checkpoints (versions < 1.2.0)
# that need to be able to unpickle the function from the checkpoint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from tests.deprecated_api import _soft_unimport_module


def test_v1_4_0_deprecated_imports():
def test_v2_0_0_deprecated_imports():
_soft_unimport_module("pytorch_lightning.utilities.argparse_utils")
with pytest.deprecated_call(match="will be removed in v1.4"):
with pytest.deprecated_call(match="will be removed in v2.0"):
from pytorch_lightning.utilities.argparse_utils import _gpus_arg_default # noqa: F401

0 comments on commit 811d37b

Please sign in to comment.