Fix sigterm signal handling (#10189)

Co-authored-by: Carlos Mocholí <[email protected]>
Lightning-AI · Oct 29, 2021 · 6ed7a0c · 6ed7a0c
1 parent 255e3ed
commit 6ed7a0c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -671,8 +671,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Fixed creation of `dirpath` in `BaseProfiler` if it doesn't exist ([#10073](https://github.com/PyTorchLightning/pytorch-lightning/pull/10073))
 
 
-- Fixed an issue with `pl.utilities.seed.reset_seed` converting the `PL_SEED_WORKERS` environment variable to `bool` ([#10099](https://github.com/PyTorchLightning/pytorch-lightning/pull/10099))
+- Fixed incorrect handling of sigterm ([#10189](https://github.com/PyTorchLightning/pytorch-lightning/pull/10189))
+
 
+- Fixed an issue with `pl.utilities.seed.reset_seed` converting the `PL_SEED_WORKERS` environment variable to `bool` ([#10099](https://github.com/PyTorchLightning/pytorch-lightning/pull/10099))
 
 
 ## [1.4.9] - 2021-09-30

diff --git a/pytorch_lightning/trainer/connectors/signal_connector.py b/pytorch_lightning/trainer/connectors/signal_connector.py
@@ -39,8 +39,7 @@ def register_signal_handlers(self) -> None:
         if self._is_on_slurm():
             log.info("Set SLURM handle signals.")
             sigusr1_handlers.append(self.slurm_sigusr1_handler_fn)
-
-        sigterm_handlers.append(self.sigterm_handler_fn)
+            sigterm_handlers.append(self.sigterm_handler_fn)
 
         # signal.SIGUSR1 doesn't seem available on windows
         if not self._is_on_windows():