Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin server): an instance for every request #12020

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix(plugin server): an instance for every request #12020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/plugin-server-instance-leak.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: "**Plugin Server**: fix an issue where every request causes a new plugin instance to be created"
type: bugfix
scope: PDK
2 changes: 1 addition & 1 deletion kong/runloop/plugin_servers/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ function get_instance_id(plugin_name, conf)

if instance_info
and instance_info.id
and instance_info.conf and instance_info.conf.__key__ == key
and instance_info.conf and instance_info.conf.__plugin_id == key
then
-- exact match, return it
return instance_info.id
Expand Down