Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Setup automated releases #57

Merged
merged 11 commits into from
Feb 27, 2023
Merged

Conversation

Ambro17
Copy link
Contributor

@Ambro17 Ambro17 commented Dec 13, 2022

Publish a new pypi release when a github release is created

Solves #56

.github/workflows/publish.yaml Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
@Ambro17
Copy link
Contributor Author

Ambro17 commented Dec 19, 2022

Hello! Were you able to reach @andrew-d to setup the pypi token?

@Kludex
Copy link
Owner

Kludex commented Feb 15, 2023

Unfortunately, I can't create GH releases... I'll let this PR in standby in case we move python-multipart to an organization.

@Kludex Kludex mentioned this pull request Feb 15, 2023
@Ambro17
Copy link
Contributor Author

Ambro17 commented Feb 15, 2023

We can modify the trigger so it runs on a git tag. That way we can publish with your current permissions

@Kludex
Copy link
Owner

Kludex commented Feb 15, 2023

Ok, that works

@Ambro17
Copy link
Contributor Author

Ambro17 commented Feb 15, 2023

Just changed it to run on every git tag that starts with v and is followed by anything. It can be more restrictive or less. Here are the docs of the supported syntax https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-branches-and-tags

And here i got the answer https://stackoverflow.com/questions/61891328/trigger-github-action-only-on-new-tags

types: [published]
push:
tags:
- 'v*' # Run on every git tag starting with "v". i.e: v1.5.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tags here are just the version, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, for example git tag v0.0.5 + git push should trigger this workflow

@Kludex
Copy link
Owner

Kludex commented Feb 27, 2023

Gracias @Ambro17 :)

@Kludex Kludex merged commit a4f2f40 into Kludex:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants