Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified furst_optics.feed_optics.FeedOptic to be a generic class. #24

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Modified furst_optics.feed_optics.FeedOptic to be a generic class. #24

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d4c5d7
Modified `furst_optics.feed_optics.FeedOptic` to be a generic class.
byrdie Sep 2, 2024
b7dbd1d
black
byrdie Sep 2, 2024
5bb61a4
black
byrdie Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Modified furst_optics.feed_optics.FeedOptic to be a generic class.
  • Loading branch information
@byrdie
byrdie committed Sep 2, 2024
commit 0d4c5d7c8937f037e63c953196d1118dd5b31930
6 changes: 5 additions & 1 deletion furst_optics/feed_optics/_feed_optics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from typing import Generic
import dataclasses
import numpy as np
import astropy.units as u
Expand All @@ -17,6 +18,9 @@ class FeedOptic(
optika.mixins.Pitchable,
optika.mixins.Translatable,
furst_optics.abc.AbstractRowlandComponent,
Generic[
furst_optics.typevars.MaterialT,
]
):
"""
Model of the FURST feed optics.
Expand Down Expand Up @@ -118,7 +122,7 @@ class FeedOptic(
The length of the optic used to hold it in its mount.
"""

material: None | optika.materials.AbstractMaterial = None
material: furst_optics.typevars.MaterialT = None
"""
The coating material used to make the optic reflective
in the target spectral range.
Expand Down
Loading