Rewrite the Introduction of the instrument paper. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instrument paper.
byrdie
force-pushed
the
instrument-intro-rewrite
branch
from
4699257 to
2afe31f
Compare
byrdie
force-pushed
the
instrument-intro-rewrite
branch
from
a1b55b3 to
af2e6df
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
kankelborg
reviewed
Oct 19, 2023
Comment on lines
+13
to
+14
| The light emitted by the solar \TR\ and corona varies significantly as a function | ||
| of position, wavelength, and time. |
kankelborg
reviewed
Oct 19, 2023
| $\lambda$ is wavelength, and $t$ is time. | ||
| The ideal solar imaging spectrograph would capture $I(x, y, \lambda, t)$ with high resolution in $x$, $y$, $\lambda$, | ||
| and $t$ \textit{and} over a wide \FOV\, wavelength range, and time period. | ||
| Of course, the temporal dimension is privileged, so we often reduce the problem to capturing a 3D spatial/spectral |
There was a problem hiding this comment.
privileged: This makes no sense to me.
kankelborg
reviewed
Oct 19, 2023
Comment on lines
34
to
36
| Approaching this ideal is the fast tunable filtergraph (\ie\ fast tunable Fabry--P\'erot etalons, \eg\ the GREGOR | ||
| Fabry--P{\'e}rot Interferometer, \citep{Puschmann12}), but the materials do not exist to extend this technology to | ||
| \EUV\ wavelengths shortward of $\sim$\SI{150}{\nano\meter}~\citep{2000WuelserFP}. |
kankelborg
reviewed
Oct 19, 2023
| and $t$ \textit{and} over a wide \FOV\, wavelength range, and time period. | ||
| Of course, the temporal dimension is privileged, so we often reduce the problem to capturing a 3D spatial/spectral | ||
| cube at a particular time $t_0$: $I(x, y, \lambda, t_0)$. | ||
| Since we use 2D detectors, this means that we must find a way to flatten the 3D cube into two dimensions |
There was a problem hiding this comment.
...we use 2D detectors to capture an exposure at some time
Instead of "the 3D cube...without losing information", how about "the remaining three dimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.