Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite: Add coverage for some "unhappy" paths (error paths) #46

Draft
wants to merge 1 commit into
base: dpa/warn_if_unexpected_params-2
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 7, 2025

@DilumAluthge DilumAluthge force-pushed the dpa/more-ci-coverage branch 2 times, most recently from 3ce5d00 to fe1c317 Compare February 7, 2025 20:26
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.05%. Comparing base (19e1470) to head (29acb23).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           dpa/warn_if_unexpected_params-2      #46      +/-   ##
===================================================================
+ Coverage                            94.11%   97.05%   +2.94%     
===================================================================
  Files                                    2        2              
  Lines                                  102      102              
===================================================================
+ Hits                                    96       99       +3     
+ Misses                                   6        3       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilumAluthge DilumAluthge force-pushed the dpa/warn_if_unexpected_params-2 branch from 02461ec to df626ee Compare February 9, 2025 20:31
@DilumAluthge DilumAluthge force-pushed the dpa/more-ci-coverage branch 2 times, most recently from 3e8d640 to 346dd24 Compare February 9, 2025 22:07
@DilumAluthge DilumAluthge force-pushed the dpa/warn_if_unexpected_params-2 branch from 540e0a1 to 344d45c Compare February 9, 2025 22:12
@DilumAluthge
Copy link
Member Author

Coverage after this PR: 97%

@DilumAluthge DilumAluthge force-pushed the dpa/warn_if_unexpected_params-2 branch from 344d45c to 19e1470 Compare February 9, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant