Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reactant] refactor toolchains to better use Yggdrasil's cross-compilers #10008

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[Reactant] refactor toolchains to better use Yggdrasil's cross-compilers #10008

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b48bcaa
pass `bb_target`, `bb_full_target` as env variables
mofeing Dec 13, 2024
b86a3ba
bump commit
mofeing Dec 13, 2024
e55b068
bump commit
mofeing Dec 13, 2024
32bdeb2
clean code
mofeing Dec 13, 2024
cd92334
fix `export` expressions
mofeing Dec 13, 2024
27493ed
set same toolchain for all targets
mofeing Dec 13, 2024
b8ba063
bump commit
mofeing Dec 13, 2024
efe381f
stop passing bb_target env vars by action envs
Dec 15, 2024
28c3a81
copy yggdrasil-generated toolchain files
Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions R/Reactant/build_tarballs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ repo = "https://github.com/EnzymeAD/Reactant.jl.git"
version = v"0.0.26"

sources = [
GitSource(repo, "899668ab6a4121a63fc8a725d988bc736ae1474f"),
GitSource(repo, "4761cce5187023e52f2a3b81cedfffd63683cecb"),
FileSource("https://github.com/wsmoses/binaries/releases/download/v0.0.1/bazel-dev",
"8b43ffdf519848d89d1c0574d38339dcb326b0a1f4015fceaa43d25107c3aade")
]
Expand All @@ -21,6 +21,9 @@ cd Reactant.jl/deps/ReactantExtra
echo Clang version: $(clang --version)
echo GCC version: $(gcc --version)

cp $BAZEL_HOST_TOOLCHAIN toolchain/yggdrasil/ygg_host.bzl
cp $BAZEL_TARGET_TOOLCHAIN toolchain/yggdrasil/ygg_target.bzl

if [[ "${bb_full_target}" == x86_64-apple-darwin* ]]; then
# LLVM requires macOS SDK 10.14.
pushd $WORKSPACE/srcdir/MacOSX10.*.sdk
Expand Down Expand Up @@ -81,11 +84,11 @@ BAZEL_BUILD_FLAGS+=(--define=grpc_no_ares=true)

BAZEL_BUILD_FLAGS+=(--define=llvm_enable_zlib=false)
BAZEL_BUILD_FLAGS+=(--verbose_failures)

BAZEL_BUILD_FLAGS+=(--action_env=TMP=$TMPDIR --action_env=TEMP=$TMPDIR --action_env=TMPDIR=$TMPDIR --sandbox_tmpfs_path=$TMPDIR)
BAZEL_BUILD_FLAGS+=(--host_cpu=k8)
BAZEL_BUILD_FLAGS+=(--host_crosstool_top=@//:ygg_cross_compile_toolchain_suite)
# BAZEL_BUILD_FLAGS+=(--extra_execution_platforms=@xla//tools/toolchains/cross_compile/config:linux_x86_64)
BAZEL_BUILD_FLAGS+=(--crosstool_top=@//:ygg_cross_compile_toolchain_suite)

if [[ "${bb_full_target}" == *darwin* ]]; then
BAZEL_BUILD_FLAGS+=(--define=gcc_linux_x86_32_1=false)
Expand Down Expand Up @@ -117,7 +120,6 @@ if [[ "${bb_full_target}" == *darwin* ]]; then
fi
BAZEL_BUILD_FLAGS+=(--linkopt=-fuse-ld=lld)
BAZEL_BUILD_FLAGS+=(--linkopt=-twolevel_namespace)
# BAZEL_BUILD_FLAGS+=(--crosstool_top=@xla//tools/toolchains/cross_compile/cc:cross_compile_toolchain_suite)
BAZEL_BUILD_FLAGS+=(--define=clang_macos_x86_64=true)
BAZEL_BUILD_FLAGS+=(--define HAVE_LINK_H=0)
BAZEL_BUILD_FLAGS+=(--macos_minimum_os=10.14)
Expand All @@ -143,7 +145,6 @@ if [[ "${bb_full_target}" == *linux* ]]; then
if [[ "${bb_full_target}" == *86* ]]; then
BAZEL_BUILD_FLAGS+=(--platforms=@//:linux_x86_64)
else
BAZEL_BUILD_FLAGS+=(--crosstool_top=@//:ygg_cross_compile_toolchain_suite)
BAZEL_BUILD_FLAGS+=(--platforms=@//:linux_aarch64)
BAZEL_BUILD_FLAGS+=(--cpu=aarch64)
BAZEL_BUILD_FLAGS+=(--@xla//xla/tsl/framework/contraction:disable_onednn_contraction_kernel=True)
Expand Down