add global fastmath removal to news. #44983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViralBShah
reviewed
Apr 14, 2022
|
changes made. |
ericphanson
reviewed
Apr 28, 2022
Co-authored-by: Eric Hanson <[email protected]>
67 tasks
|
The underlying PR is not on 1.8 so this should not have a backport label. |
|
Hi @ViralBShah since you added backport I assumed this would go in. "The underlying PR" my (trivial, not adding feature just dropping functionality for safety) PR #41638 was merged since Apr 14, I'm just unclear how to add it "on 1.8". |
|
Seems like I added the label mistakenly - if the PR is not on 1.8, we can't have the news there, naturally. It will just make it into 1.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #41638