Change TypeVars in UnionAlls to print as var"" syntax #34888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes unnamed type variables to print as valid syntax, via the
`var""` printing macro.
For example, before this commit, `Vector{<:Bool}` printed as a
non-syntactic string:
```julia
julia> Vector{<:Bool}
Array{#s16,1} where #s16<:Bool
```
And now it prints as a valid, syntactic expression:
```julia
julia> Vector{<:Bool}
Array{var"#s46",1} where var"#s46"<:Bool
```
|
Agreed on all counts --- this is a good improvement, but it would be better to use valid identifiers to begin with. |
JeffBezanson
approved these changes
Feb 26, 2020
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
This changes unnamed type variables to print as valid syntax, via the
`var""` printing macro.
For example, before this commit, `Vector{<:Bool}` printed as a
non-syntactic string:
```julia
julia> Vector{<:Bool}
Array{#s16,1} where #s16<:Bool
```
And now it prints as a valid, syntactic expression:
```julia
julia> Vector{<:Bool}
Array{var"#s46",1} where var"#s46"<:Bool
```
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
This changes unnamed type variables to print as valid syntax, via the
`var""` printing macro.
For example, before this commit, `Vector{<:Bool}` printed as a
non-syntactic string:
```julia
julia> Vector{<:Bool}
Array{#s16,1} where #s16<:Bool
```
And now it prints as a valid, syntactic expression:
```julia
julia> Vector{<:Bool}
Array{var"#s46",1} where var"#s46"<:Bool
```
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes unnamed type variables to print as valid syntax, via the
var""printing macro introduced in #32408, as part of addressing #34887.For example, this makes
Vector{<:Bool}print as a valid, syntactic expression:I'm not totally in love with this approach, since it makes the types much more verbose, but it's a good first step towards resolving #34887. I don't feel confident enough to delve into the type creation to change the type variable's actual name when instantiating the UnionAll to be a valid identifier, as proposed in #34887.