-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack
#777
stack
#777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
==========================================
+ Coverage 89.08% 91.56% +2.48%
==========================================
Files 2 2
Lines 174 249 +75
==========================================
+ Hits 155 228 +73
- Misses 19 21 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
the arrays along new dimensions. | ||
They also accept arrays as separate arguments, rather than a single collection. | ||
|
||
!!! compat "Julia 1.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comment needed in Compat.jl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed them, since they are pretty long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Bogumił was referring to the compat annotation (which doesn't make as much sense bc you can use the function pre-1.9 if you are using Compat), not the whole docstring. IMO the docstring is still useful from Compat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't disagree that it's useful but I think most Compat definitions don't retain the docstring for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. I can restore them, and edit the compat note to say when this is in Base julia? Perhaps that should be the policy.
This reverts commit 7afdb54.
From JuliaLang/julia#43334