Build LIMIT only if size is strictly positive (#586)

JetBrains · Jun 20, 2019 · 71ef31f · 71ef31f
1 parent fc42e5a
commit 71ef31f
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/exposed/src/main/kotlin/org/jetbrains/exposed/sql/vendors/Default.kt b/exposed/src/main/kotlin/org/jetbrains/exposed/sql/vendors/Default.kt
@@ -107,7 +107,14 @@ abstract class FunctionProvider {
     open fun replace(table: Table, data: List<Pair<Column<*>, Any?>>, transaction: Transaction): String
         = transaction.throwUnsupportedException("There's no generic SQL for replace. There must be vendor specific implementation")
 
-    open fun queryLimit(size: Int, offset: Int, alreadyOrdered: Boolean) = "LIMIT $size" + if (offset > 0) " OFFSET $offset" else ""
+    open fun queryLimit(size: Int, offset: Int, alreadyOrdered: Boolean) = buildString {
+        if (size > 0) {
+            append("LIMIT $size")
+            if (offset > 0) {
+                append(" OFFSET $offset")
+            }
+        }
+    }
 
     open fun <T : String?> groupConcat(expr: GroupConcat<T>, queryBuilder: QueryBuilder) = buildString {
         append("GROUP_CONCAT(")