Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench playground #6128

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Bench playground #6128

merged 4 commits into from
Feb 25, 2025

Conversation

fmaste
Copy link
Contributor

@fmaste fmaste commented Feb 21, 2025

Description

  • Simplify benchkmarking profiles: separation of concerns for "era" and "overlay" useful for the improvements below.
  • Overlays can now be described in Haskell, alongside the profile definition.
  • Get ready for faster dev cycles with make playground-NAME.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste fmaste marked this pull request as ready for review February 21, 2025 15:10
@fmaste fmaste requested a review from a team as a code owner February 21, 2025 15:10
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmaste fmaste force-pushed the bench-playground branch 2 times, most recently from 73f308a to 57e3686 Compare February 25, 2025 13:56
@fmaste fmaste enabled auto-merge February 25, 2025 14:20
@fmaste fmaste added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit 17b2081 Feb 25, 2025
23 checks passed
@fmaste fmaste deleted the bench-playground branch February 25, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants