-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wait-for-hydra
for when there are too many check runs
#6127
Conversation
b4abef8
to
195e592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I think it would be good to expand the cases for "$conclusion"
as well, so that the default case produces an error.
10cfb11
to
854ed96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have this fixed
Description
When there are more than 30 (the default pagination page size) check runs, the Hydra statuses are sometimes not found, blocking progress.
We can query only the status we need instead of searching though all statuses.
Also includes #6126, as requested, so we only have to merge one PR.
Checklist
New tests are added if needed and existing tests are updated.Any changes are noted in theCHANGELOG.md
for affected packageThe version bounds in.cabal
files are updatedCode is linted withhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionCode is formatted withstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionCode builds on Linux, MacOS and Windows forghc-8.10.7
andghc-9.2.7