Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wait-for-hydra for when there are too many check runs #6127

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

dermetfan
Copy link
Contributor

@dermetfan dermetfan commented Feb 20, 2025

Description

When there are more than 30 (the default pagination page size) check runs, the Hydra statuses are sometimes not found, blocking progress.

We can query only the status we need instead of searching though all statuses.

Also includes #6126, as requested, so we only have to merge one PR.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated.
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@dermetfan dermetfan requested review from a team as code owners February 20, 2025 21:20
@dermetfan dermetfan force-pushed the fix-gha-wait-for-hydra branch 2 times, most recently from b4abef8 to 195e592 Compare February 20, 2025 21:28
Copy link
Contributor

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I think it would be good to expand the cases for "$conclusion" as well, so that the default case produces an error.

@dermetfan dermetfan force-pushed the fix-gha-wait-for-hydra branch from 10cfb11 to 854ed96 Compare February 20, 2025 23:02
Copy link
Contributor

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this fixed

@neilmayhew neilmayhew enabled auto-merge February 21, 2025 13:59
@neilmayhew neilmayhew added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 21, 2025
@johnalotoski johnalotoski added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 21, 2025
@johnalotoski johnalotoski added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 5795f29 Feb 21, 2025
23 checks passed
@johnalotoski johnalotoski deleted the fix-gha-wait-for-hydra branch February 21, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants