-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeVersion tracer for providing metrics #5764
Conversation
fd7eb00
to
0ad9399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a really nice improvement, thank you!
This will be great to have! I've had some (thankfully local) runs I've had to re-run because I lost track of which compiler was used for it. |
6678a9b
to
26cd79f
Compare
e818219
to
2e2f5db
Compare
3d86aed
to
d3e11e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally
- please add full namespace to
BlockForgingUpdate b -> sendEKGDirectInt ekgDirect' "forging_enabled"
- changelog entry / minor version bump for
trace-dispatcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jutaro , great work, and very useful.
This adds a new trace message, which adds new metrics. Here is an example of what it provides:
NB in the actual Prometheus output, this is 1 line only; newlines have been inserted here for readability only.
Additionally, it provided an alternative representation of the same data as trace messages for both machines and humans. Here are examples of how the data will be represented:
Machine Trace Message:
{"at":"2024-04-08T12:30:08.89384608Z","ns":"Version.NodeVersion","data":{"applicationName":"cardano-node","applicationVersion":"8.10.0","architecture":"x86_64","compilerName":"ghc","compilerVersion":"8.10","gitRevision":"f3fabe88bfc83f5e9c2a9d7af2293857cd8212c3","osName":"linux"},"sev":"Info","thread":"5","host":"deusXmachina"}
Human Trace Message:
[2024-04-08 13:46:26.5169Z]deusXmachina:Version.NodeVersion cardano-node 8.10.0 git rev f3fabe8 - linux-x86_64 - ghc-8.10