Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Refactor normalize string method #201

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Refactor normalize string method #201

merged 4 commits into from
Jul 13, 2020

Conversation

jgwerner
Copy link
Member

@jgwerner jgwerner commented Jul 12, 2020 •
edited
Loading

  • Change normalize_name_for_containers to normalize_string
  • Move normalize string tasks (username and course id) to setup_course_hook
  • Update tests

#198

@jgwerner jgwerner added the refactor Move code around to keep things DRY label Jul 12, 2020
@jgwerner jgwerner requested a review from netoisc July 12, 2020 22:03
@jgwerner jgwerner self-assigned this Jul 12, 2020
@codecov
Copy link

codecov bot commented Jul 12, 2020 •
edited
Loading

Codecov Report

Merging #201 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          18       18           
  Lines        1128     1128           
=======================================
  Hits          896      896           
  Misses        232      232
Impacted Files Coverage Δ
src/illumidesk/grades/handlers.py 78.57% <ø> (ø)
src/illumidesk/authenticators/authenticator.py 92.39% <100.00%> (ø)
src/illumidesk/authenticators/utils.py 97.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3fbd86...44b25b7. Read the comment docs.

@jgwerner jgwerner requested a review from netoisc July 13, 2020 23:01
netoisc
netoisc approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jgwerner jgwerner merged commit d331cc0 into IllumiDesk:main Jul 13, 2020
@jgwerner jgwerner deleted the refactor/normalize-strings branch July 13, 2020 23:35
@jgwerner jgwerner mentioned this pull request Jul 15, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@netoisc netoisc netoisc approved these changes

Assignees

@jgwerner jgwerner

Labels
refactor Move code around to keep things DRY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgwerner @netoisc