Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transit cross account #5

Merged
merged 5 commits into from
Jul 31, 2020
Merged

feat: Transit cross account #5

merged 5 commits into from
Jul 31, 2020

Conversation

kennburger
Copy link
Member

PR summary

Transit cross account function

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • [X ] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Support Transit cross account function

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #5 into master will increase coverage by 0.12%.
The diff coverage is 97.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   87.87%   87.99%   +0.12%     
==========================================
  Files          34       34              
  Lines        5848     5890      +42     
==========================================
+ Hits         5139     5183      +44     
+ Misses        709      707       -2     
Impacted Files Coverage Δ
...m_cloud_networking_services/direct_link_apis_v1.py 90.02% <91.66%> (+0.16%) ⬆️
...oud_networking_services/transit_gateway_apis_v1.py 90.85% <98.41%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9666b2f...caa003e. Read the comment docs.

@kennburger kennburger merged commit 41137c6 into master Jul 31, 2020
@kennburger kennburger deleted the transit-cross-account branch July 31, 2020 08:23
ajay-malhotra1 pushed a commit that referenced this pull request Aug 1, 2020
# [0.1.0](v0.0.2...v0.1.0) (2020-08-01)

### Features

* **deploy:** enable semantic release ([a77ad73](a77ad73))
* **direct_link:** renamed DirectLinkApisV1 to DirectLinkV1 ([e50bf15](e50bf15))
* Transit cross account ([#5](#5)) ([41137c6](41137c6))
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants